Add getNeighbors() and tilesToFeatureCollection() #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
mrnix
reviewed
Oct 21, 2021
| const z = tile[2]; | ||
|
|
||
| return [ | ||
| [x - 1, y - 1, z], // NW |
There was a problem hiding this comment.
it doesn't check for valid tiles.
what about [-1, -1, 3]
There was a problem hiding this comment.
It's been quite some time since I touched this and I've lost all familiarity. Do you already have a function that checks for valid tiles? If not, can you define what such a check might look like?
There was a problem hiding this comment.
If I remember correctly many other functions don't perform these checks (I assume for performance reasons), Is there a reason this function is special in that regard?
mrnix
suggested changes
Oct 21, 2021
|
@mrnix Update on this PR & review? |
|
@mrnix ? |
|
Apparently I have to submit a review completely to comment on a review on github? Hopefully my comments are visible now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to do two different pull request for two different things, but this request is dependent on #39
Adds two new methods:
getNeighbors()tilesToFeatureCollection()Let me know if these are additions you are willing to accept, hopefully these are not gratuitous.